Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split service settings #95

Merged
merged 3 commits into from
Oct 19, 2023
Merged

split service settings #95

merged 3 commits into from
Oct 19, 2023

Conversation

morsecodist
Copy link
Contributor

@morsecodist morsecodist commented Oct 19, 2023

I refactored my last change to use the pydantic settings. But different plugins have different settings and I found myself importing from platformics in a workflow plugin. This felt wrong to me and not just because of plugins. I think we will end up with all sorts of settings specific to one service or the other. I think the most elegant way to solve this is with a common settings object that is extended in each service. Which is what I have done here. I also moved settings out of api in platformics because I felt it was confusing to have it under api if it also contains CLI settings. Also the parse_obj method is deprecated so I updated to model_validate as recommended by pydantic.

@morsecodist morsecodist marked this pull request as ready for review October 19, 2023 16:52
@morsecodist morsecodist merged commit 5bdc72a into main Oct 19, 2023
4 checks passed
@morsecodist morsecodist deleted the tmorse-settings-split branch October 19, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants