Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored my last change to use the pydantic settings. But different plugins have different settings and I found myself importing from
platformics
in a workflow plugin. This felt wrong to me and not just because of plugins. I think we will end up with all sorts of settings specific to one service or the other. I think the most elegant way to solve this is with a common settings object that is extended in each service. Which is what I have done here. I also moved settings out ofapi
inplatformics
because I felt it was confusing to have it underapi
if it also contains CLI settings. Also theparse_obj
method is deprecated so I updated tomodel_validate
as recommended by pydantic.